search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.05k stars 345 forks source link

FlakyTest TestPrometheusMetrics #3072

Open MustafaSaber opened 1 month ago

MustafaSaber commented 1 month ago

https://github.com/zalando/skipper/actions/runs/9004582619/job/24737898384?pr=3059

--- FAIL: TestPrometheusMetrics (0.06s)
    --- FAIL: TestPrometheusMetrics/Measuring_all_serves_by_the_hosts_split_by_hosts,_only_should_measure_served_latency_by_route_without_method_and_code. (0.01s)
        prometheus_test.go:1049: 'skipper_serve_host_duration_seconds_sum{host="host1"} 0.015' metric not present on the result of metrics service
FAIL
FAIL    github.com/zalando/skipper/metrics  0.407s
AlexanderYastrebov commented 1 month ago

Likely test checks metrics before they updated. We can add a small delay to mitigate if this reappears.