search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.04k stars 345 forks source link

OPA: Add decision outcome to span #3096

Closed mjungsbluth closed 3 weeks ago

mjungsbluth commented 3 weeks ago

This PR brings the information on the span for the opaAuthorizeRequest* filters to the same level as the metrics by including the decision's result if it is available under the opa.decision.allowed tag.

This allows to pull similar metrics from the traces as directly from the Skipper instances.

szuecs commented 3 weeks ago

:+1:

AlexanderYastrebov commented 3 weeks ago

:+1:

AlexanderYastrebov commented 3 weeks ago

DCO check seems stuck, I've closed/reopened the PR, lets see.

szuecs commented 3 weeks ago

retry DCO

AlexanderYastrebov commented 3 weeks ago

DCO check is not working currently https://github.com/dcoapp/app/issues/211