search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.04k stars 345 forks source link

routing: measure CreateFilter latency #3115

Closed AlexanderYastrebov closed 1 week ago

AlexanderYastrebov commented 1 week ago

Add MeasureFilterCreate method to Metrics interface similar to existing MeasureFilterRequest and MeasureFilterResponse.

The alternative would be to use MeasureSince but then filter name would have to be embedded into metric key.

MustafaSaber commented 1 week ago

should we update docs on the same PR?

szuecs commented 1 week ago

:+1:

szuecs commented 1 week ago

should we update docs on the same PR?

In this case I think we can do the docs later, because we should make sure we have useful docs in our operations doc. We should write about it why would you should monitor this, so I think we should add a new paragraph to monitor some control plane parts.

MustafaSaber commented 1 week ago

👍