search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.04k stars 345 forks source link

OPA: Add response status to control plane traces #3118

Closed mjungsbluth closed 1 week ago

mjungsbluth commented 1 week ago

The current span for control plane requests of the Open Policy Agent based filters does not include the actual response from the control plane.

Apart from hard network errors this makes it hard to pinpoint authN / authZ failures or intermittent unavailability (5xx status) of the control plane.

This PR both adds the control plane responses' http status code to the spans and also flags them as erroneous for all status with a value of 4xx or 5xx.

AlexanderYastrebov commented 1 week ago

:+1:

MustafaSaber commented 1 week ago

Does this needs to be reflected in Open Policy Agent span docs?

szuecs commented 1 week ago

:+1:

szuecs commented 1 week ago

Does this needs to be reflected in Open Policy Agent span docs?

let's document operations things if we have more experience with operating it.