search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.09k stars 350 forks source link

OPA: Fail fast on discovery or bundle download errors #3120

Open mjungsbluth opened 3 months ago

mjungsbluth commented 3 months ago

As part of #3119, this PR changes the behaviour on starting up OPA instances inside the OPA based Skipper filters.

Currently even in the face of download errors of bundles, the default timeout of 30s is applied.

By using listeners both for bundle download and discovery bundle download, we can detect a failure early despite the respective plugins still waiting for the bundles to become available.

Still a draft because tests are missing, there are some cleanups in the code that need to be done.

Pending: Unregister discovery and bundle plugin listeners.

Pushpalanka commented 2 months ago

Addressing the race condition in the upstream as a part of this reported issue.

Pushpalanka commented 1 month ago

Moving to draft as using OPA 0.67.0, which is yet to be taken by Skipper dependency upgrades.

MustafaSaber commented 1 month ago

Moving to draft as using OPA 0.67.0, which is yet to be taken by Skipper dependency upgrades.

OPA 0.67.1 is merged now.