search

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress
https://opensource.zalando.com/skipper/
Other
3.12k stars 351 forks source link

go get is broken #781

Closed aryszka closed 6 years ago

aryszka commented 6 years ago

when getting the skipper packages via go get github.com/zalando/skipper/... in a clean environment, the build fails:

:) go get github.com/zalando/skipper/...
# github.com/zalando/skipper/metrics
src/github.com/zalando/skipper/metrics/prometheus.go:261:57: too many arguments in call to prometheus.NewProcessCollector
    have (int, string)
    want (prometheus.ProcessCollectorOpts)
# github.com/zalando/skipper/opentracingplugin/tracers/basic
runtime.main_main·f: function main is undeclared in the main package
# github.com/zalando/skipper/opentracingplugin/tracers/instana
runtime.main_main·f: function main is undeclared in the main package
# github.com/zalando/skipper/opentracingplugin/tracers/jaeger
runtime.main_main·f: function main is undeclared in the main package
# github.com/zalando/skipper/opentracingplugin/tracers/lightstep
runtime.main_main·f: function main is undeclared in the main package
:(
aryszka commented 6 years ago

related: https://github.com/golang/go/wiki/Modules#why-does-installing-a-tool-via-go-get-fail-with-error-cannot-find-main-module

mikkeloscar commented 6 years ago

The first error is because of a broken change in the prometheus library https://github.com/prometheus/client_golang/commit/7858729281ec582767b20e0d696b6041d995d5e0