check if we can handle websockets more efficiently - Githubissues

zalando / skipper

An HTTP router and reverse proxy for service composition, including use cases like Kubernetes Ingress

https://opensource.zalando.com/skipper/

Other

3.07k stars 347 forks source link

check if we can handle websockets more efficiently #960

Open szuecs opened 5 years ago

szuecs commented 5 years ago

Right now we connect plain sockets and use for { io.Copy() } and copiy streams in both direction so we have 1 goroutine per upgraded connection regardless if we have a websocket or something else.

Interesting resources to check:

talk: https://speakerdeck.com/eranyanay/going-infinite-handling-1m-websockets-connections-in-go
code examples: https://github.com/eranyanay/1m-go-websockets
lib: https://github.com/gobwas/ws

In skipper: check proxy/upgrade.go and proxy/proxy.go (makeUpgrade..())

szuecs commented 3 years ago

There is also https://pkg.go.dev/github.com/christopher-dG/go-obs-websocket, but I did not look into it