zalando / spilo

Highly available elephant herd: HA PostgreSQL cluster using Docker
Apache License 2.0
1.53k stars 382 forks source link

Install wal-g from a precompiled bin #1006

Closed hughcapet closed 1 month ago

hughcapet commented 1 month ago
macedigital commented 1 month ago

Are there tests covering the check whether wal-g supports brotli ?

It looks like we're relying on the fact that precompiled binaries (may have) enabled the optional brotli compression support by explicitly setting USE_BROTLI=1 at build time.

hughcapet commented 1 month ago

@macedigital Tests are currently covering our default configuration (not to use WAL-G for backup) I tested this specific setup though (see the reverted commit)

macedigital commented 1 month ago

I think we should add tests for supported compression algorithms in general to Spilo, as lz4 or lzma might be dropped at one time in future as well. This would help detecting issues with creating or restoring from backups early.

Something like:

for algo in lz4 lzma brotli; do
  # ... verify backups can be created and restored from $algo
done

WDYT?

hughcapet commented 1 month ago

depending on how fast you need this fix to be rolled out and if you want to volunteer implementing it now:) (this can also be a follow-up PR)

macedigital commented 1 month ago

depending on how fast you need this fix to be rolled out and if you want to volunteer implementing it now:) (this can also be a follow-up PR)

Could be a follow-up PR as fixing applying a fix for the missing brotli support is urgent.

macedigital commented 1 month ago

:+1:

hughcapet commented 1 month ago

👍