zalando / spilo

Highly available elephant herd: HA PostgreSQL cluster using Docker
Apache License 2.0
1.55k stars 382 forks source link

Add toggle to enable grouping log by date/instance in s3 #941

Closed idanovinda closed 10 months ago

idanovinda commented 11 months ago

Objective:

This pull request introduces a new feature that enhances our log file management system. It enables users to efficiently group log files based on the date stored in an S3 bucket, providing a more streamlined approach to downloading log files. With date-based log grouping, instance rotations become less of a hassle. Users no longer need to check the instance names of deleted instances when downloading log files of a specific date.

How to Use:

Users can easily enable the new feature by setting the newly introduced environment variable LOG_GROUPED_BY_DATE to True. This environment variable serves as a toggle to activate the date-based grouping functionality. By default, if LOG_GROUPED_BY_DATE is not specified or set to False, the system will continue to group log files by instance ID or POD ID, ensuring backward compatibility.

Jan-M commented 10 months ago

Looks good to me

sdudoladov commented 10 months ago

:+1:

idanovinda commented 10 months ago

👍