chore: better support different number of rings

zalando / tech-radar

Visualizing our technology choices

https://opensource.zalando.com/tech-radar/

MIT License

1.6k stars 622 forks source link

chore: better support different number of rings #113

Open ggarber opened 1 year ago

ggarber commented 1 year ago

Better support for variable number of rings removing the hardcoded constant 4 in different places.

bocytko commented 1 year ago

Thanks for the PR. Do you have a branch with a fully working example? I tried to check out your branch and add a 5th ring and the change breaks due to undefined radius for the new ring.

A few more things will break:

cartesian_max uses index 3 which is a hardcoded 4-1
legend_calculation calculates the legend offsets and at least the calculation for dy needs to consider more rings via a formula with ring and 12 rather than the naive switch using mod 2

rishiraj88 commented 4 months ago

Nice idea, going forward.