zalando / tech-radar

Visualizing our technology choices
https://opensource.zalando.com/tech-radar/
MIT License
1.6k stars 622 forks source link

Show new blips as stars and add table of ring descriptions #150

Closed SoumayaMauthoorMOJ closed 2 months ago

SoumayaMauthoorMOJ commented 3 months ago

Hello @bocytko I really like this visualisation and would like to propose a few backwards-compatible changes:

Here is what my radar looks like with these changes: https://moj-analytical-services.github.io/data-and-analytics-engineering-tech-radar/

Screenshot 2024-06-24 at 22 24 36

SoumayaMauthoorMOJ commented 2 months ago

Hello any thoughts about these changes? Here's the link to your tech radar showing how the changes are backwards compatible: https://soumayamauthoormoj.github.io/tech-radar/

bocytko commented 2 months ago

@SoumayaMauthoorMOJ thanks for the PR and for providing the two examples, which made the review much easier. I like the changes with adding the star for the new entry.

I added suggestions directly in the code. These should be pretty straightforward. If there are further questions, just ask.

SoumayaMauthoorMOJ commented 2 months ago

Hey @bocytko thanks for the feedback I've now made all the requested changes as a single commit. I wasn't sure if you wanted the shape logic to be moved = 0 - no-change (〇) or else - no-change (〇) so I've left it as-is

bocytko commented 2 months ago

Thank you for the adjustments and for the contribution!

I will apply a few cosmetic fixes in a follow-up PR.