zalando / zalando.github.io

Open Source Documentation and guidelines for Zalando developers
https://opensource.zalando.com
MIT License
89 stars 38 forks source link

Mar-updates #403

Closed hpdang closed 5 years ago

hpdang commented 5 years ago

Signed-off-by: hpdang dhppat@gmail.com

zincr[bot] commented 5 years ago

🤖 zincr found 2 problems , 0 warnings

❌ Approvals
❌ Specification
✅ Large Commits
✅ Dependency Licensing

Details on how to resolve are provided below


Approvals

All proposed changes must be reviewed by project maintainers before they can be merged

Not enough people have approved this pull request - please ensure that 1 additional user, who have not contributed to this pull request approve the changes.

Please ensure the follow issues are resolved:

perploug commented 5 years ago

@hpdang - see comments above on the internal language versus communicating this to an external audience - other than that it looks good

hpdang commented 5 years ago

@perploug can we merge?

perploug commented 5 years ago

@hpdang - let me just try to add a bit of context to the maintainer tuesdays part, oh and also I'm attending the github satelite event as a speaker in may, so will add that as well, and then it is ready

perploug commented 5 years ago

👍