zalando / zalenium

A flexible and scalable container based Selenium Grid with video recording, live preview, basic auth & dashboard.
https://opensource.zalando.com/zalenium/
Other
2.39k stars 575 forks source link

chore: Externalise intialDelay & period of liveliness probe #1204

Open kripaliz opened 4 years ago

kripaliz commented 4 years ago

Thanks for contributing to Zalenium! Please give us as much information as possible to merge this PR quickly.

Description

Externalise initialDelaySeconds and periodSeconds of liveliness probe.

Motivation and Context

When the video PVC contains a lot of data, hub pod startup seems to take longer. The issue seems to happen when using AWS EFS for PVC, perhaps due to relatively slow IO on EFS. Increasing the initialDelaySeconds helps.

How Has This Been Tested?

Tested this in a cluster where the default initialDelaySeconds wasn't enough and using a higher value gave more time for hub pod to start.

Types of changes

Checklist: