what`s the bese practice process holiday feature

zalandoresearch / pytorch-ts

PyTorch based Probabilistic Time Series forecasting framework based on GluonTS backend

MIT License

1.21k stars 190 forks source link

what`s the bese practice process holiday feature #32

Open goomhow opened 3 years ago

goomhow commented 3 years ago

Now,i placed the holidays feature in 'taget',but in deepar it should be 'feat_dynamic_real' i`m not sure placed it in 'target' is the best way.

kashif commented 3 years ago

@goomhow please check the _m5.py file where I prepare the M5 dataset and assign holiday features into the feat_dynamic_real key. Target is not the place to put it.