zalf-rdm / geonode-k8s

A Kubernetes helm chart for the geospacial webapplication Geonode
https://geonode-k8s.readthedocs.io/en/latest/
GNU General Public License v2.0
12 stars 7 forks source link

Feature: allow to use an existing configmap to replace nginx conf #112

Closed AlexGacon closed 7 months ago

AlexGacon commented 8 months ago

Feature Description

To facilitate integration of a geonode instance with an external application, it would be great to have the possibility to add CORS origin info into NGINX configuration.

Proposed Solution

Additional Information

Any additional information or context that may be helpful in implementing the feature.

AlexGacon commented 8 months ago

I considered that the underlying file name is not changed but perhaps it is better to allow its configuration too.

AlexGacon commented 8 months ago

I can take care of it if it is ok with you.

mwallschlaeger commented 8 months ago

yes I can understand the requirement here. I guess for most cases it would be enough to overwrite the configuration just partially. Like only the geoserver, or add addition configuration to a specific part. But sure for some use-cases also using a a whole self written config will be required.

If you create a PR i can definitely take a look at it.

AlexGacon commented 8 months ago

Ok. You will receive my PR when done.

AlexGacon commented 7 months ago

I updated the issue following the discussion in the proposed PR.