search

zalf-rdm / geonode-k8s

A Kubernetes helm chart for the geospacial webapplication Geonode
https://geonode-k8s.readthedocs.io/en/latest/
GNU General Public License v2.0
12 stars 7 forks source link

Bug: support of existing secret for external postgres is not complete #128

Closed AlexGacon closed 6 months ago

AlexGacon commented 6 months ago

Bug Description

When you want to use an existing secret to provide user/passwords for databases hosted outside the chart, it does not work: the definition of postgres.external_postgres.secret.existingSecretName only blocks the generation of the internal secrets but the deployments don't reference the defined secret.

Moreover since there is 1 secret name for all the user/passwords, the current usage is not compatible, since we have 1 secret for each couple, with the same values.

Reproduction Steps

  postgres:
    external_postgres:
      enabled: true
      secret:
        existingSecretName: "toto"

Behavior

The chart should reference the existing secret when defined and should use different names for each user/password couples.

Additional Information

Any additional information or context that may be helpful in resolving the bug.

AlexGacon commented 6 months ago

@mwallschlaeger I will work on that

AlexGacon commented 6 months ago

@mwallschlaeger do you think it will be possible to review my PR in the coming days?