Task: Remove ingress externalPort parameter

[ridoo]

Task Description

geonode.ingress.externalPort had to be set as mandatory parameter. This was due to mistakenly usage as ingress target port. However, now it can be optional.

Additional Information

• Add a check for nil here: https://github.com/zalf-rdm/geonode-k8s/blob/bde327c89a35c8c137f4f620ebcc57c0de1c7a85/deployment/geonode/templates/_helpers.tpl#L85
• Check for Oauth config

[ridoo]

@mwallschlaeger can you confirm that geonode.ingress.externalPort even could be removed? I mean, would you run the whole GeoNode Application over a different port than 80 or 443? For these the http scheme should define the port implicitly.

In those cases GEONODE_LB_PORT is set to either 80 or 443 GeoNode's setup logic leaves it empty. For PUBLIC_PORT I did not find any reference which uses/reads it :shrug: . It seems to be a relict, and gets replaced by GEONODE_LB_PORT if set, anyways.

[mwallschlaeger]

yes i can confirm a static variable would be fine

[ridoo]

You mean it is ok to remove it completely from the setup, right?

[mwallschlaeger]

yes we can