zalf-rdm / geonode-k8s

A Kubernetes helm chart for the geospacial webapplication Geonode
https://geonode-k8s.readthedocs.io/en/latest/
GNU General Public License v2.0
12 stars 7 forks source link

Task: Separate SITE_URL related settings from ingress config #67

Closed ridoo closed 10 months ago

ridoo commented 10 months ago

Task Description

Currently, externalDomain and externalScheme are part of the ingress configuration. However, this config is optional and one could choose to disable it. It is confusing/surprising, that (at least) the mentioned settings are still required within the setup to construct important configuration, like the GEONODE_LB_HOST_IP.

We should also wrap the ingress manifest with {{ if (eq .Values.geonode.ingress.enabled true) }}. It raises errors in cases where ingress is turned in favor of a different ingress setup and where externalDomain is configured (to resolve the described issue):

Error: UPGRADE FAILED: cannot patch "geonode-nginx-ingress" with kind Ingress: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: host "<your-domain>" and path "/" is already defined in ingress <namespace/ingress-name>