zalf-rpm / monica

license
Mozilla Public License 2.0
24 stars 10 forks source link

NDeposition is added to the soil nitrate pool #25

Open tierlingj opened 4 years ago

tierlingj commented 4 years ago

In SoilTransport::fq_NDeposition(), the annual NDeposition (given as user input in site.json) is added to the soil nitrate pool, instead of the ammonium pool, which would be meaningful and as it is stated in the function's comment.


 * @brief Calculation of N deposition
 * Transformation of annual N Deposition into a daily value,
 * that can be used in MONICAs calculations. Addition of this
 * transformed N deposition to ammonium pool of top soil layer.
 *
 * @param vs_NDeposition
 *
 * Kersebaum 1989
 */
void SoilTransport::fq_NDeposition(double vs_NDeposition) {
  //Daily N deposition in [kg N ha-1 d-1]
  double vq_DailyNDeposition = vs_NDeposition / 365.0;

  // Addition of N deposition to top layer [kg N m-3]
  vq_SoilNO3[0] += vq_DailyNDeposition / (10000.0 * soilColumn[0].vs_LayerThickness);

}
bergm commented 4 years ago

We're looking into it. Thank you for the report.