zalify / easy-email-editor

Easy Email Editor is a feature-rich, top open-source SaaS email editor based on React and MJML.
https://email.maocanhua.cn/
MIT License
1.51k stars 323 forks source link

Conflicting peer dependencies #200

Open mikicho opened 1 year ago

mikicho commented 1 year ago

First, thanks for this AMAZING project!!! I get this warning while installing the recommended packages.

➜  email-editor npm install --save easy-email-core easy-email-editor easy-email-extensions react-final-form
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: react-codemirror2@7.2.1
npm WARN Found: react@17.0.2
npm WARN node_modules/react
npm WARN   peer react@"^17.0.2" from easy-email-core@4.3.11
npm WARN   node_modules/easy-email-core
npm WARN     easy-email-core@"*" from the root project
npm WARN     2 more (easy-email-editor, easy-email-extensions)
npm WARN   11 more (react-dom, easy-email-editor, easy-email-extensions, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer react@">=15.5 <=16.x" from react-codemirror2@7.2.1
npm WARN node_modules/react-codemirror2
npm WARN   react-codemirror2@"^7.2.1" from easy-email-extensions@4.4.0
npm WARN   node_modules/easy-email-extensions
npm WARN
npm WARN Conflicting peer dependency: react@16.14.0
npm WARN node_modules/react
npm WARN   peer react@">=15.5 <=16.x" from react-codemirror2@7.2.1
npm WARN   node_modules/react-codemirror2
npm WARN     react-codemirror2@"^7.2.1" from easy-email-extensions@4.4.0
npm WARN     node_modules/easy-email-extensions
npm WARN deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

added 129 packages, and audited 130 packages in 2m

found 0 vulnerabilities
m-Ryan commented 1 year ago

It can be ignored for now, react-codemirror2 compatible with the current React version. react-codemirror2 is no longer maintained, maybe it will be replaced by monaco-editor.

mikicho commented 1 year ago

Should I close this? Or you want to keep this open for tracking?

m-Ryan commented 1 year ago

Keep this open, I will close it if it is fixed.