search

zalmoxisus / crossbuilder

Building web, Electron, Cordova and Chrome apps, and cross-browser extensions with React, Redux and Webpack. "Write once, deploy everywhere" concept in practice.
MIT License
484 stars 50 forks source link

[E2E test] More timeout setting in Travis #13

Closed jhen0409 closed 8 years ago

jhen0409 commented 8 years ago

The E2E tests is often an error in Travis CI. I think we may need more timeout in CI. (use is-ci npm package)

@zalmoxisus you think?

zalmoxisus commented 8 years ago

Yeh:). Just was looking into this problem. Great package, by the way (didn't know about it), just wondering, if travis sometimes needs more timeout, maybe some users also need it having not so fast machine. Why not just to increase it for all tests? I was thinking add 10000 ms as a global timeout.

zalmoxisus commented 8 years ago

Added a global timeout. Even though, E2E tests sometime fail to open Chrome or to load the extension (not sure), which doesn't seem to be solved with a bigger timeout. Reloading the build on travis helps, so it could be related to some bugs on their side. What do you think, @jhen0409?

zalmoxisus commented 8 years ago

The container-based infrastructure seems to be more stable. There are problems only for chrome apps test. Sometimes the app window cannot be opened. Fixed in https://github.com/zalmoxisus/browser-redux/commit/9d3162e39fe9e0b21fd85e1267e93f4ab00d09cc by making a second attempt to open the window.