zalmoxisus / redux-devtools-extension

Redux DevTools extension.
MIT License
13.49k stars 1.01k forks source link

Allow font-size to be increased #752

Open besenwagen opened 3 years ago

besenwagen commented 3 years ago

Firefox on Windows 10: all text in the Developer Tools Redux tab is very hard to read on my internal monitor and impossible to read on external monitor. Developer Tools font-size changes are not inherited. So the extension is unusable without a screen magnifier, or a physical looking glass. 🤷‍♂️

Two days ago was the 10th anniversary of the ADA.

See also https://github.com/zalmoxisus/redux-devtools-extension/issues/708

KevinGhadyani-minted commented 3 years ago

Any issues using [CTRL][+] and [CTRL][-]?

besenwagen commented 3 years ago

Any issues using [CTRL][+] and [CTRL][-]?

Beyond having no effect ("Developer Tools font-size changes are not inherited.")?

KevinGhadyani-minted commented 3 years ago

Sorry if I don't understand, but if I click in the devtools and hit [CTRL][+], it zooms the devtools only, not the browser view.

Default 100% Zoom:

image

After [CTRL][+] 3 times:

image

KevinGhadyani-minted commented 3 years ago

Also verified in Firefox:

image

[CTRL][MOUSE_WHEEL_UP] works:

image

I see the issue you're having now. It's not responding to [CTRL][+] or [CTRL][0], only the mouse wheel for zooming. This is a Firefox bug. All plugins react like this including React Devtools.

To be clear, Firefox's devtools are written in React and Redux (redux'ception), so it's surprising they haven't seen this issue in testing.

I'm betting it's a separate style prop that's not listening to the correct key commands when wrapping 3rd party plugins.

besenwagen commented 3 years ago

[CTRL][MOUSE_WHEEL_UP] works:

Thanks for that. I haven't used a mouse in 10 years so I'd never have thought about emulating the wheel. :-))

To be clear, Firefox's devtools are written in React and Redux (redux'ception), so it's surprising they haven't seen this issue in testing.

Meh. I am warming towards the idea, however, that the Vue devtools can't be zoomed in and out with +/- either because their host is written in React. 😂

david-shortman commented 3 years ago

Meh. I am warming towards the idea, however, that the Vue devtools can't be zoomed in and out with +/- either because their host is written in React. 😂

According to this issue, the problem isn't React, but Firefox: https://github.com/facebook/react/issues/20876 Firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1583716

This issue can probably be closed.

KevinGhadyani-minted commented 3 years ago

Np. Feel free to close it!

AlexanderPershin commented 3 months ago

I'm using devtools with firefox, and zoom level is not inherited from browser devtools. The main issue is that when I zoom in using [mouse wheel + ctrl] and then close Redux devtools and open again zoom level is being reset. Is there a way to persist zoom level once it was changed?