search

zalmoxisus / redux-devtools-extension

Redux DevTools extension.
MIT License
13.5k stars 1.01k forks source link

Redux DevTools triggering a false positive 'This page is using the production build of React. ✅' #829

Closed Fernando-Espinosa closed 2 years ago

Fernando-Espinosa commented 2 years ago

This issue was reviewed at: Issue Link

And the conclusion was that Redux DevTools was triggering a false positive in certain pages not built with react.

Repro steps

  1. Open any web app not made with React (e.g.: youtube.com, amazon.com, github.com, gmail.com, lucidchart.app)
  2. The react icon is ON and the popover message says:

'This page is using the production build of React. ✅'

Methuselah96 commented 2 years ago

Do you mind moving this issue over to https://github.com/reduxjs/redux-devtools? It is the new home for the extension and this repo is no longer updated.

bvaughn commented 2 years ago

Already filed:https://github.com/reduxjs/redux-devtools/issues/1030

Methuselah96 commented 2 years ago

18 seconds. ;)

Methuselah96 commented 2 years ago

Will take a look soon.

gaearon commented 2 years ago

Should this repo be archived? I thought Redux DevTools is unmaintained by looking at the commit log. Didn't realize there's another repo.

Methuselah96 commented 2 years ago

It should be, unfortunately I only have write access and not admin access. I'll add a note to the README.

Methuselah96 commented 2 years ago

I submitted a fixed extension to the Chrome Web Store a few hours ago that should fix this issue. Still waiting for it to be approved.

bvaughn commented 2 years ago

@Methuselah96 Would love to see the fix! I don't see any commits pushed to https://github.com/reduxjs/redux-devtools

Edit I see it: https://github.com/reduxjs/redux-devtools/pull/1031/

Methuselah96 commented 2 years ago

I've added a note to the README and a pinned issue about the new repo. Still waiting on the extension to be approved in the Chrome Web Store.