zalmoxisus / remote-redux-devtools

Redux DevTools remotely.
http://zalmoxisus.github.io/monitoring/
MIT License
1.81k stars 139 forks source link

Crashing in react-native when not debugging #130

Closed martinchristov closed 5 years ago

martinchristov commented 5 years ago

Running on RN 0.57.7 The following line: import { composeWithDevTools } from 'remote-redux-devtools'

causes the app to crash if remote debugging is not turned on.

simulator screen shot - iphone 8 - 2018-12-27 at 08 21 44

"your browser does not have a secure random generator. If you don't need unpredictable IDs, you can use nanoid/non-secure"

zalmoxisus commented 5 years ago

Thanks for the report! It happens only with remote-redux-devtools@0.5.15, not with 0.5.14, right?

luispccruz commented 5 years ago

Same problem here.

luispccruz commented 5 years ago

A issue was created too at: https://github.com/facebook/react-native/issues/22780

luispccruz commented 5 years ago

Another user made this fix: Fix in : index.js in line : 23 change var _nanoid = require('nanoid/non-secure')

vsantana commented 5 years ago

Same here!

leo1995m commented 5 years ago

Same here

VanilsonFernandes commented 5 years ago

Same here. :tired_face:

zalmoxisus commented 5 years ago

Can someone check if downgrading to remote-redux-devtools@0.5.14 fixes the issue?

luispccruz commented 5 years ago

Can someone check if downgrading to remote-redux-devtools@0.5.14 fixes the issue?

Im using the 0.5.12 version and i have the same issue.

zalmoxisus commented 5 years ago

@mitziin that's strange, as nanoid was introduced in 0.5.14 last version in https://github.com/zalmoxisus/remotedev-utils/pull/9. Before it was shortid and nobody reported such problems.

luispccruz commented 5 years ago

The 0.5.12 version has a wildcard on the module "remotedev-utils": "^0.1.1". my npm ls: ─┬ remote-redux-devtools@0.5.12 └─┬ remotedev-utils@0.1.4 └─┬ shortid@2.2.14 └── nanoid@2.0.0

zalmoxisus commented 5 years ago

@mitziin you're right. Thanks! It should be fixed in 0.5.16. I'll update that package as well.

luispccruz commented 5 years ago

thank you!

luispccruz commented 5 years ago

@zalmoxisus can you create a release with this fix?

zalmoxisus commented 5 years ago

@mitziin published remote-redux-devtools@0.5.16 now, thanks again for the details.