search

zalmoxisus / remote-redux-devtools

Redux DevTools remotely.
http://zalmoxisus.github.io/monitoring/
MIT License
1.8k stars 138 forks source link

`serialize: {immutable: Immutable}` option #78

Open unindented opened 7 years ago

unindented commented 7 years ago

On redux-devtools-extension, there's the option to pass serialize: {immutable: Immutable}. That option is not documented on this repo... Is there a reason for that?

tsaiDavid commented 7 years ago

@unindented - If I'm not mistaken, it's not supported. The standard redux-devtools-extension is using his remotedev-serialize

@zalmoxisus - What approach do you suggest we take - I could possibly help with a PR since I need to use this.

zalmoxisus commented 7 years ago

It was added in remotedev-utils. A pr to pass this option, wold be much appreciated.

tsaiDavid commented 7 years ago

@zalmoxisus Wow, thanks for the quick reply - thanks for pointing that out! Sounds good, I can work on that. Will I have to use remotedev-utils/src/importState.jsat all then? Thanks for all your work 👍

zalmoxisus commented 7 years ago

We need just to import getSeralizeParameter in here and use like so:

const serialize = getSeralizeParameter(config)

Then pass it to stringify from remotedev-utils, which should be used instead of jsan's stringify.

Also we'll need to use importState instead of https://github.com/zalmoxisus/remote-redux-devtools/blob/master/src/devTools.js#L99-L101.

Basically, the long-term plan is to move all the common part from Redux DevTools Extension into remotedev-utils and reimplement it here.

unindented commented 7 years ago

@tsaiDavid any progress here? How can I help? I don't know enough about this project's internals to understand @zalmoxisus's steps. If somebody can detail them even more I'll try.