search

zalmoxisus / remote-redux-devtools

Redux DevTools remotely.
http://zalmoxisus.github.io/monitoring/
MIT License
1.8k stars 138 forks source link

Cannot set suppressConnectErrors to false #84

Closed nikoskleidis closed 7 years ago

nikoskleidis commented 7 years ago

When I set suppressConnectErrors to false, this condition: suppressConnectErrors = options.suppressConnectErrors ? options.suppressConnectErrors : true; sets it back to true I think it should be: suppressConnectErrors = options.suppressConnectErrors !== undefined ? options.suppressConnectErrors : true;

zalmoxisus commented 7 years ago

Yes, it seems that it was missed when changed in https://github.com/zalmoxisus/remote-redux-devtools/commit/886ec92bc864f5288a944f0ad8371d843861e892. /cc @G-Rath

G-Rath commented 7 years ago

@nikoskleidis & @zalmoxisus Agreed - Sorry for the mistake, and thanks for the catch :)

zalmoxisus commented 7 years ago

Thanks for the fix! It is published as remote-redux-devtools@0.5.11.