search

zalmoxisus / remotedev-server

Connect Redux DevTools extension to a remote app.
MIT License
183 stars 43 forks source link

Allow configurable maximum request body in worker #28

Open jenschelkopf opened 8 years ago

jenschelkopf commented 8 years ago

It will likely be a common use case for remotedev-server to handle large request bodies since redux trees can get large for complex applications.

By default remotedev-server will support request bodies of up to 100kb, which is pretty small as far as redux state goes. Requests larger than that size will receive a 413 response from the server.

Please add a configuration option for the maximum request body. Configurable is good so users can limit exposure to the security risk of large request bodies to an amount appropriate for their operational environment.

Here's a good example of setting the limit in the bodyParser middleware: http://stackoverflow.com/a/19965089/194957

zalmoxisus commented 8 years ago

We also need this to be implemented for sockets, but it's hardcoded to 16mb for now.

Ricardo-C-Oliveira commented 7 years ago

This would a huge improvement! My application has to load a full GeoJSON file into memory, which is 24mb but will likely get 10 times bigger. Because of this I'm unable to to use the remote redux tool to debug the app :(.

zalmoxisus commented 7 years ago

@Ricardo-C-Oliveira, not sure how fast the serialization will be in such cases, it could freeze the browser for several seconds-minutes. Better to strip unnecessary data using actionSanitizer /stateSanitizer.