Minor CSS improvements for tweakpane UI

zalo / CascadeStudio

A Full Live-Scripted CAD Kernel in the Browser

https://zalo.github.io/CascadeStudio/

MIT License

1.03k stars 129 forks source link

Minor CSS improvements for tweakpane UI #124

Closed Billiam closed 2 years ago

Billiam commented 2 years ago

Fixes a couple of issues:

The existing label styles added some unexpected padding and hover colors to checkboxes, so I scoped those to the topnav instead
Added a scrollbar when the gui panel extends beyond the height of the viewer window

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/zalo/cascade-studio/96Su1QwngpQwD1k1N5MqeMmczuFz
✅ Preview: https://cascade-studio-git-fork-billiam-feature-improve-ui-styles-zalo.vercel.app

Irev-Dev commented 2 years ago

Without knowing much context, A pointer-events: none; might need to be added to the CSS somewhere.

Billiam commented 2 years ago

Thanks for taking a look, I completely missed that. I've moved the overflow styles up to the .gui-panel element, so there's no height: 100% div blocking interactions.

zalo commented 2 years ago

Testing looks good to me; thank you @Billiam !

Billiam commented 2 years ago

Sure, thank you!