search

zalsaeed / cgav

Certificate Generation and Verification
GNU General Public License v3.0
3 stars 1 forks source link

Fix: Hashes for Certificates Generated for Different Events are the Same #36

Closed wesamhamad closed 4 months ago

wesamhamad commented 4 months ago

In certificate.py, we using the recipient's email and name to generate the hash:

self.certificate_hash = util.small_hash(self.recipient_email + self.recipient_name)

This means that if we have recipients with the same name and email across different events, their hashes will also be the same, leading to collisions.

Hint: we need to also use certificate_event_id