search

zama-ai / fhevm

A Solidity library for interacting with fhEVM.
Other
408 stars 80 forks source link

fix: Various Typescript type checker errors #583

Closed silasdavis closed 3 days ago

silasdavis commented 4 weeks ago

Also improved a few bits of config.

This is a WIP since I was passing by anyway, all of the type checker issue can be eliminated with a bit more effort. I think a lot of what remains can be solved by making use of the Typechain types.

Let me know if this effort is likely to get merged and I might try and finish it off (although I may need to defer on some tests where I'm unsure if I may end up making logical changes inadvertently).

jatZama commented 4 weeks ago

Thank you for your work. But since many of those files will be refactored and moved by the end of this week in another repo, I will for the moment just take into account your remark about the missing view modifier in the ACL contract. All other typescript and prettier issues will be handled later after the refactor in the new repo, your work will give us then a head start for correcting TS related issues.

silasdavis commented 4 weeks ago

Could you give an idea of the destination structure, will this refactor/new repo replace fhevm or will you be slicing the code/functionality here in some other way?

Will you still be using hardhat/ethers or some other framework for deployment?

jatZama commented 4 weeks ago

Could you give an idea of the destination structure, will this refactor/new repo replace fhevm or will you be slicing the code/functionality here in some other way?

Will you still be using hardhat/ethers or some other framework for deployment?

fhevm will mainly contain the TFHE.sol library (and GatewayContract and library for now). The core contracts (ACL, TFHEExecutor, KMSVerifier, InputVerifier, FHEPayment) will be moved to another repo and imported inside fhevm. Deployment will still use hardhat, but we plan to add a Foundry template soon.

silasdavis commented 4 weeks ago

your work will give us then a head start for correcting TS related issues.

Got it, I'll leave this open but feel free to close when appropriate for you guys.

sonarcloud[bot] commented 5 days ago

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.4% Duplication on New Code

See analysis details on SonarQube Cloud