chore(gpu): update gpu parameters

zama-ai / tfhe-rs

TFHE-rs: A Pure Rust implementation of the TFHE Scheme for Boolean and Integer Arithmetics Over Encrypted Data.

Other

906 stars 143 forks source link

chore(gpu): update gpu parameters #1229

Closed guillermo-oyarzun closed 3 months ago

guillermo-oyarzun commented 3 months ago

closes: please link all relevant issues

PR content/description

Check-list:

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Relevant issues are marked as resolved/closed, related issues are linked in the description
[ ] Check for breaking changes (including serialization changes) and add them to commit message following the conventional commit specification

IceTDrinker commented 3 months ago

2^-40 parameters will be removed only 2^-64 will remain

are you sure about the pfail of those parameters btw ?

guillermo-oyarzun commented 3 months ago

@IceTDrinker, those parameters were generated with the optimizer without using the bind_crypto method, so the pfail constraint should've been imposed correctly. Do we have another way to validate the pfail?

IceTDrinker commented 3 months ago

I'm guessing those are the updated GPU params using the branch we discussed ?

guillermo-oyarzun commented 3 months ago

I'm guessing those are the updated GPU params using the branch we discussed ?

Yup, we managed to generate them with the help of Sam. We also ran the pfail -40 just for comparison purposes.

IceTDrinker commented 3 months ago

I'm guessing those are the updated GPU params using the branch we discussed ?

Yup, we managed to generate them with the help of Sam. We also ran the pfail -40 just for comparison purposes.

all right, let me check something on my end

agnesLeroy commented 3 months ago

@IceTDrinker we're good to merge that PR I think, do you confirm?

IceTDrinker commented 3 months ago

@IceTDrinker we're good to merge that PR I think, do you confirm?

Let me run some last checks as discussed :) but likely it will be good yes !