search

zamarrowski / react-ionicons

A React Ionicon component https://react-ionicons.netlify.app/
Apache License 2.0
192 stars 28 forks source link

Inherit color by default #69

Open DURK opened 3 years ago

DURK commented 3 years ago

Hi @zamarrowski, I'm really happy I found your project, after struggling to implement Ionicons in a non-Ionic React-project. Awesome work! 👍

Question I just found out that to let the icons use the current color of whatever text/button/block I put them in, I have to override the color option to "inherit". For example: <ArrowBackOutline color="inherit" />

Does it make sense to make that the default, instead of #000000?

zamarrowski commented 3 years ago

Hi @DURK, yep, make sense. Let me try it in some scenarios to ensure it works and if it's fine I will change the default color to inherit