search

zamaudio / zam-plugins

Collection of LADSPA/LV2/VST/JACK audio plugins for high-quality processing
http://www.zamaudio.com/?p=976
GNU General Public License v2.0
265 stars 37 forks source link

ZamSynth general fix up #66

Closed falkTX closed 5 years ago

falkTX commented 5 years ago

This consists of the following:

  1. Disable presets. In DPF, since some months ago, having presets and state at the same time implies the full state API (where the plugin needs to return its full current state). It was the only way to make things work. ZamSynth was returning empty state, we just added the function there to make it build before. Since it does not actually have any presets, I took out that option from it. and State gets saved by the host properly now

  2. repaint after UI state changes

  3. postpone UI setState calls till the next uiIdle. ZamSynth was calling setState for each mouse movement, and the host could not keep up with the amount of data being thrown at it. Now it caches the data, and checks if setState call is needed during uiIdle.

  4. small whitespace/indentation cleanup, where it really was hard to see what was going on. Your code mixes tabs and spaces, which is not pretty. I did not want to make the diff too big, so I only touched parts that I felt essential.

zamaudio commented 5 years ago

Thanks for this, but I don't actually ship this plugin as part of the build as it was considered experimental.

Please see the top level Makefile for plugins that are considered important.

falkTX commented 5 years ago

oh I know, the plugin is not built by default. I was looking for something to test the states with, and this seemed a perfect fit. I like the synth too, it just needs a little love <3

zamaudio commented 5 years ago

Merged manually