zamaudio / zam-plugins

Collection of LADSPA/LV2/VST/JACK audio plugins for high-quality processing
http://www.zamaudio.com/?p=976
GNU General Public License v2.0
271 stars 35 forks source link

Extra mouse input for easier knob editing #82

Closed noisecode3 closed 1 year ago

noisecode3 commented 3 years ago

Hi, I added some extra mouse button input. Right click work like holding down Ctrl and middle mouse activate default knob value like shift key. If you don't like it, never mind.

zamaudio commented 3 years ago

@martinbangens thank you for this. Can you also please consider adding it to DPF? I would like to keep things in sync with what @falkTX wants to maintain in DPF, otherwise we get out of sync.

noisecode3 commented 3 years ago

Sure @zamaudio ! btw I think It better if I did else after the check for ev.button == 3. because if that one is not true ALL other mouse buttons must sett fRightClicked = false. IF you know what I mean :) for safety and to make it cleaner. But it will only take those other 2 mouse button anyway from the first check

noisecode3 commented 3 years ago

I see how I could add that in ImageWidgets.cpp in DPF but the real question is. To knob or not to knob? What dose you're mouse say about this? What dose my mouse say about this? It should be harmless, it's just to extra mouse button inputs. And also what's the exact correct way to add that functionality?? I need a day to think about this. also there a lot going on over here.

noisecode3 commented 3 years ago

I tested all plugins, jack stand alone, LV2 in Ardour and VST2 in Renoise. I haven't tested DSSI yet, I must try to add this to DPF. It seem to work best with some if statements like this, I did try another approach but I messed up middle mouse click, this first one is simple and I reverted back to it. I added right mouse + ctrl click that I think people will like for mastering and give them better control.

I think I'm done here, have fun!

zamaudio commented 1 year ago

@noisecode3 I cannot merge this, if you are still keen to do these changes, i suggest adding a PR to distrho/dpf

noisecode3 commented 1 year ago

Sure I could look into it, in the holidays, think we can close this PR for now :)