search

zamaudio / zam-plugins

Collection of LADSPA/LV2/VST/JACK audio plugins for high-quality processing
http://www.zamaudio.com/?p=976
GNU General Public License v2.0
265 stars 37 forks source link

Fix invalid use of dpf states #89

Closed falkTX closed 1 year ago

falkTX commented 1 year ago

The convolver based plugins were using dpf states in an incorrect way, where it was only handled internally and never through the host or UI. As such, there is no need to enable states on these plugins at all.

Updated DPF again while at it, why not.

Worth noting that on LV2 and CLAP, parameter changes happen during realtime audio, so the way you setup the code is for sure going to trigger xruns. Would be preferred to change these to properly use states, if you want to get rid of xruns. The downside is that most hosts are not able to show these on a generic UI, and thus we would need to rely on the custom GUI to be able to change/set these. The plugin DSP side only by itself cannot set them.

Could be a future thing too, in case you want to tag a new release sooner rather than later.

falkTX commented 1 year ago

btw for an example of using states in plugins see https://github.com/DISTRHO/DPF/tree/main/examples/States

falkTX commented 1 year ago

Rebased against your changes just now.