zamaudio / zam-plugins

Collection of LADSPA/LV2/VST/JACK audio plugins for high-quality processing
http://www.zamaudio.com/?p=976
GNU General Public License v2.0
270 stars 35 forks source link

Feature request - ZaMultiCompX2 - Mono button on LF band #95

Closed jrigg closed 1 year ago

jrigg commented 1 year ago

A mono button on the LF band of ZaMultiCompX2 would be very useful for mastering for vinyl.

zamaudio commented 1 year ago

@jrigg I'm a bit reluctant to change the number of controls on plugins, as this breaks LV2. The MAX/Average switch doesn't seem to have much effect. Maybe I could make the average side of the switch toggle LF mono?

jrigg commented 1 year ago

Fair point about LV2 breakage. I overlooked that as I mostly use the JACK version. Losing the Average setting and repurposing the switch to toggle LF mono would work for me, but I don't know how other users would feel.

zamaudio commented 1 year ago

@jrigg I suggest you try jalv.gtk with the LV2 versions because you can save/load presets which the JACK version cannot do. I have created a branch with your suggested changes. https://github.com/zamaudio/zam-plugins/compare/master...zamulticompx2-mono-lf can you try it out and let me know if you think its worth merging?

jrigg commented 1 year ago

Looks good on quick initial test but ran out of time for more extensive testing. I'll do more testing tomorrow (UK time) and report back.

jrigg commented 1 year ago

Still good after further testing. On my test material (heavy rock in low B tuning) the mono LF mode sounds more powerful and focussed than in MAX mode. I'd probably use this whatever the release format, not just vinyl.

One possible caveat would be that hard-panned MF and HF sounds might shift in the stereo image due to the averaging, but it didn't cause a noticeable problem here.

BTW the reason I mostly use the JACK version is lower CPU load. It's about 8% on my Ryzen sytem, dropping to 4% if I hide the window (in cwm window manager) after settimg it up. The LV2 in jalv.gtk3 is about 10% load, dropping to 9% when hiding the window. IIRC jalv.gtk (GTK2) was better, but jalv recently dropped GTK2 support.

zamaudio commented 1 year ago

@jrigg merged in 2ef55cf

jrigg commented 1 year ago

Thanks for your work on this. Best wishes for 2023.

zamaudio commented 1 year ago

@jrigg in case you didn't notice this new feature, seems to work with JACK version:

$ DPF_SCALE_FACTOR=1.5 ZaMultiCompX2

jrigg commented 1 year ago

Thanks for the tip. That's a useful feature.