Closed knewter closed 10 years ago
zambal
commented
10 years ago Thanks for noticing, that's definitely a bug indeed. Currently all tag/element macros are generated uniformly by one macro and to be honest I never have put much thought into exceptions like this. Fixing this particular bug by making an exception for script tags would be quite easy, but maybe it would be better to think of a more generic solution where these kind of exceptions can be specified on a per tag case.
knewter
commented
10 years ago Honestly, all self-closing tags can be just empty tags afaik. Why not just default to that instead?
On Sun, Feb 2, 2014 at 5:00 PM, Vincent Siliakus notifications@github.comwrote:
Thanks for noticing, that's definitely a bug indeed. Currently all tag/element macros are generated uniformly by one macro and to be honest I never have put much thought into exceptions like this. Fixing this particular bug by making an exception for script tags would be quite easy, but maybe it would be better to think of a more generic solution where these kind of exceptions can be specified on a per tag case.
Reply to this email directly or view it on GitHubhttps://github.com/zambal/eml/issues/5#issuecomment-33916219 .
Josh Adams CTO | isotope|eleven http://www.isotope11.com cell 215-3957 work 476-8671 x201
zambal
commented
10 years ago You're right. I had two reasons for generating self-closing tags, but thinking about it some more those reasons are pretty weak:
Both reasons don't outweigh being correct without introducing extra complexity, so I'm going to follow your advice. Thanks! :)
zambal
commented
10 years ago Fixed in a340684a799c14e65faf23467ea5b10d79a7fb39
Presently, if you do the following:
Eml will output . This is not valid except when rendering xhtml, and browsers render it inappropriately generally, with the script tag gobbling up all the remaining content.
Eml should output a closing script tag rather than make them self-closing.