search

zambezi / caballo-vivo

Glue code for pure RxJS applications to connect with React-Router, and other operators
2 stars 7 forks source link

Fix peer dependencies + add jest + solve vulnerabilities #41

Closed cristiano-belloni closed 4 years ago

cristiano-belloni commented 4 years ago

Closes #38

cristiano-belloni commented 4 years ago

The gist of this is that we have to have our dependencies in devDependencies to actually use them in our tests, and in peerDependencies to alert our users that they want to install them. We don't want them in dependencies, though, because if a user installs a different version of one of the libraries, we would end up with double dependencies (and, in case of double React, a conflict).

We have big version ranges and it doesn't normally happen, but if it happens when React, for example, hits the next major, having React in dependencies will make caballo-vivo's React instance differ and clash with the user's React instance.

Closes #38