zambezi / ez-build

Zambezi build tool
MIT License
2 stars 1 forks source link

Non zero exit on error #40

Closed mstade closed 8 years ago

mstade commented 8 years ago

Description

These changes ensure we exit with a non-zero code whenever the build has non-recoverable errors.

Motivation and Context

Exit codes are used to determine the success or failure of a program, and is often the only reliable way of answering the binary question: did the damn thing work? Before, and this was an oversight, ez-build only exited with a non-zero code when it detected ignored promise rejections – build errors would still result in a zero exit code. With these changes, we ensure that if there are any errors during the build, we exit properly.

How Was This Tested?

Test added in broken-project.bats.

Types of changes

codecov-io commented 8 years ago

Current coverage is 86.59% (diff: 100%)

Merging #40 into master will increase coverage by 1.37%

@@             master        #40   diff @@
==========================================
  Files            15         15          
  Lines           257        261     +4   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            219        226     +7   
+ Misses           38         35     -3   
  Partials          0          0          

Powered by Codecov. Last update 7f88c57...9cbe09b