zambezi / ez-build

Zambezi build tool
MIT License
2 stars 1 forks source link

Fix UMD globals #45

Closed mstade closed 7 years ago

mstade commented 7 years ago

Description

These changes aim to fix an issue with exporting UMD modules that depend on other modules. The issue and fix is explained more in-depth in babel/babel#4766.

Because the babel PR has yet to be accepted or discussed, we've decided to fork the relevant plugin to enable a release separate from Babel. This is unfortunate, and whenever babel merges babel/babel#4766 or otherwise fix this issue, we should move back to that plugin.

Motivation and Context

Without this, UMD modules that have dependencies on other UMD modules will break.

How Was This Tested?

This change is both in babel and in ez-build. Tests were added to the babel PR, but remains to be added to this.

Types of changes

Checklist:

codecov-io commented 7 years ago

Current coverage is 87.68% (diff: 100%)

Merging #45 into master will decrease coverage by 0.26%

@@             master        #45   diff @@
==========================================
  Files             4         15    +11   
  Lines            83        268   +185   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits             73        235   +162   
- Misses           10         33    +23   
  Partials          0          0          

Powered by Codecov. Last update f0b1a75...88969d6