search

zambezi / ez-build

Zambezi build tool
MIT License
2 stars 1 forks source link

added targetBrowsers to postcss options for continuity, closes #51 #52

Closed DimitarChristoff closed 7 years ago

DimitarChristoff commented 7 years ago

DISCLAIMER

I would prefer to see a separate option --target-browsers-css as you may have different goals but anyway.

Description

See #51

How Was This Tested?

It honours the setting and exports / preserves -ms specific CSS properties when required

Types of changes

Checklist:

Keep in mind the cli tests do not run on windows and break, they also spawn 100s of bash*32 processes due to BAT being unable to resolve folders. Test case was added in test/fixtures/typical-project to include a transform in CSS that requires IE9 support and is set accordingly in package.json build, expected result should have -ms-transform as well as transform props.

DimitarChristoff commented 7 years ago

The build is broken because tests fail on master. I will wait for @mstade to comment. 

> @zambezi/ez-build@0.7.0 test:cli /Users/coda/projects/ez-build
> bats test/cli/*.bats

 ✗ UMD should only export default value for single export modules when add-module-exports flag is specified
   (from function `assert_equal' in file test/cli/test-util.bash, line 83,
    from function `assert_expected' in file test/cli/test-util.bash, line 59,
    in test file test/cli/add-module-exports.bats, line 15)
     `assert_expected "$(cat lib/index.js)"' failed
   ~/projects/ez-build/test/fixtures/bare-project ~/projects/ez-build
   argc: /Users/coda/projects/ez-build/bin/ez-build.js
   argv: --flags add-module-exports
   cat: lib/index.js: No such file or directory
   -- not equal
...

it's not building a lib/index.js ever - and bats tests don't even on windows - instead, they end up spawning 100s of bash.exe processes and kill the machine.

seems related to this:

Unhandled rejections: 1

Rejection #1:
TypeError: (0 , _postcss2.default)(...) is not a function
    at

inside of the log files for the builds.

codecov-io commented 7 years ago

Codecov Report

Merging #52 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          15       15           
  Lines         312      312           
=======================================
  Hits          293      293           
  Misses         19       19
Impacted Files Coverage Δ
src/builder/css.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aaac92b...9fc8b47. Read the comment docs.

DimitarChristoff commented 7 years ago

@mstade yeah, having something that checks CSS output against the -ms-transform expectation will help - I just don't know how to work with bats on a windows box.