zambezi / grid

D3 component for drawing grids
MIT License
4 stars 2 forks source link

Programmatic Grouped Rows #13

Closed gabrielmontagne closed 8 years ago

gabrielmontagne commented 8 years ago

Description

In this PR programmatic row grouping is implemented. The interface is described in the documentation part of this PR, https://github.com/zambezi/grid/blob/grouped-rows-work/man/grouped-rows.md

And example, running from a pre-release version, can be found here, http://bl.ocks.org/gabrielmontagne/1f7f21300e14be360c9ac6081db16c68

How Was This Tested?

A rig is provided in the examples, as well as the block linked above.

Types of changes

mstade commented 8 years ago

I love that you include examples with all of these things you do chief, it really helps bring the points across. Moreover, I'm going to start thinking about how we could potentially leverage these for automated testing as well. It seems to me they form ideal contexts for that.

gabrielmontagne commented 8 years ago

Thanks, @mstade , @adrian-brown has been having those same thoughts here at the office : ) It'd be great if we could set something like this up. This kind of tests are the ones I'd like to see for something like the grid, something that describe the functioning grid as we'd describe it ourselves, "I click on the expander, and I see Mr Stade under name".