zambezi / grid

D3 component for drawing grids
MIT License
4 stars 2 forks source link

Support nested animation on grid cells #26

Closed cristiano-belloni closed 8 years ago

cristiano-belloni commented 8 years ago

Description

Animations in nested cell markup throw an error. This is due to the event handler for column drop transition erroneously firing.

Motivation and Context

We're using animated components in a column component and the grid gets confused.

How Was This Tested?

Manually on a local grid

Types of changes

mstade commented 8 years ago

I wanna see the rig too :o(

gabrielmontagne commented 8 years ago

@mstade, we'll need to find a way to run react on blocks, or some non-blocks example solution. : /

mstade commented 8 years ago

@gabrielmontagne make a repo and ping it to me? I can spend some time trying to get it running. :o)

grancalavera commented 8 years ago

There's a similar discussion going on here: https://github.com/zambezi/grid-components/issues/6

CodePen has built in support for React, with the added benefit of allowing live-editing of the examples. I think all we need is create an account, the rest is already sorted out.