search

zamboni-lab / SLAW

Scalable and self-optimizing processing workflow for untargeted LC-MS
GNU General Public License v2.0
25 stars 3 forks source link

Gap filling crashes on long gradient #3

Closed adelabriere closed 2 years ago

adelabriere commented 2 years ago

The gap-filling mays crash on longer gradient with optimized parameters, as SLAW can often lead to really sensitive parameters, picking 50000+ (real) features on a long gradient. I am working on it. At the moment a workaround is to use the peakpicking/peaktable_filter to truncate the features, the default is 30000 but if you want to get a rough overview it can be lower.

It is currenty my highest priority to get this bug fixed.

adelabriere commented 2 years ago

This should be fixed in https://github.com/zamboni-lab/SLAW/commit/7aefcaf6eea38a397a6ea8e96f70e294fbdf25ef