zamtmn / metadarkstyle

73 stars 22 forks source link

PageControl headers are not properly rendered when multiline option is set #60

Open ElectronicIV opened 1 day ago

ElectronicIV commented 1 day ago

image image

When then multi-line option is set on a TPageControl only the first row of the header is properly rendered, the others following rows have only their text rendered.

It is almost impossible to visually find which tab is currently selected.

This happens in the editor and in a compiled program.

using : Lazarus - 3.6 MetaDarkStyle - latest from github OS - windows 10 pro 22H2 & windows 11 pro 21H2

ElectronicIV commented 1 day ago

Same thing with TTabControl

zamtmn commented 1 day ago

Yes. Vertical tabs not work too

klaus101 commented 16 hours ago

This is no wonder ... as actually "DrawTabControl" - just as in older versions of double commander sources too - does exclusively handle the partIds TABP_TOPTABITEM*, and so the the result is predictable (= to handle only the top items).

Newer versions of DC are working with "if (iPartId < TABP_PANE)" etc. .... i did a little test and it handles the multilined tabs too (see image). pagecontrol

I'd give to consider to check this.

(Vertical tabs won't work here though).