Job#exports returns array; not Zamzar\Export

[louismrose]

Expected Behaviour

In the following:

$job = $this->client()->jobs->get(1234)->waitForCompletion();
foreach ($job->exports as $export) {
    print_r($export);
}

I expected $export to be of type Zamzar\Export.

Current Behaviour

$export is of type array:

(
    [id] => 1
    [url] => s3://example-bucket/thumbnails/example-0.png
    [status] => successful
)

Possible Solution

I think this could be due to a slight inaccuracy in the property map for Job. I believe this line should change:

-  'export' => Export::class,
+  'exports' => [Export::class],

Steps to Reproduce

1. Create an API job with an export (or look up the ID of an existing one)
2. Run the code in the "expected behaviour section"
3. Observe that $export is of type array

Environment

• zamzar-php 2.0.3
• PHP 8.2.16

[louismrose]

This could be a breaking change due to the change in return type. (Callers will now receive an Export when they might previously have been indexing into an array).

We could either:

• Implement ArrayAccess for Export and other model types
• Fix this in the next major version (v3) of the library

[louismrose]

We discussed this as a team today, and we'd like to fix this properly behind a breaking change. We're going to target v3 of the SDK for this fix.