search

zanac / pyHPSU

Python Script to read and send commands to a Rotex HPSU
29 stars 21 forks source link

Lowercase nibble in commands_hpsu.csv #14

Open segaura opened 6 years ago

segaura commented 6 years ago

In HPSU.py the logic on "commands" require them to be defined with all nibble uppercase (e.g. if command[6:8] != "FA").

the file etc/pyHPSU/commands_hpsu.csv has a last row with some lowercase nibble

t_flow_cooling;61 00 fa 03 dd 00 00;190;d;10;w

this should be

t_flow_cooling;61 00 FA 03 DD 00 00;190;d;10;w

Spanni26 commented 6 years ago

Thats a quick fix. But I would also add a ".upper()" at HPSU.py where it is needed. Will add it at the next pull request