search

zancarius / archlinux-pkgbuilds

Various odds and ends but mostly just custom PKGBUILDs.
8 stars 4 forks source link

Ensures config files are generated by non-root #8

Closed mitchhentges closed 8 years ago

mitchhentges commented 8 years ago

Currently, the /etc/sentry folder is created and set to be owned by the sentry user, but then the config files are generated by root. This has the effect of the folder being owned by sentry, but the files within not being readable or editable

mitchhentges commented 8 years ago

Oh, also, I removed the instructions about generating the config files, because it's done automatically

zancarius commented 8 years ago

Thanks, Mitch. I'll merge this shortly.

zancarius commented 8 years ago

Sorry about the delay. I was baking cookies ahead of time for the 4th, because cookies are awesome.

I've merged the changes. I did decide to move the chown down a few lines until after the configs were generated so we don't have to include sudo in the dependencies. It's not installed in base by default, and although the instructions recommend using sudo, not everyone is likely to follow it exactly (especially if they have an aversion to installing it for whatever paranoid, or legitimate, reason might come to mind).

Really appreciate the pull request @mitchhentges! I'm glad you caught that. Thanks a ton!

mitchhentges commented 8 years ago

Cookies for the 4th? But Canada day already happened ;) Sounds good, thanks!

zancarius commented 8 years ago

LOL! Nah, in typical 'Murican fashion, I'll be doing burgers. The cookies are for fun.

Enjoy the remainder of your weekend.

Cheers, mate.