search

zane-ops / zane-ops

A self-hosted PaaS for your web services, databases, CRONs, and everything you need for your next startup.
https://zaneops.dev
MIT License
124 stars 6 forks source link

[šŸ› bug] Image validation requires credentials validation which requires image validation #302

Open Fredkiss3 opened 1 week ago

Fredkiss3 commented 1 week ago

Describe the bug

it can make it so that we canā€™t modify the image because the credentials are invalid and we canā€™t modify the credentials because the image will not work with the credentials

Simple solution

Validate the image only on deploy and on service creation. And handle errors when pulling the image correctly by also giving users actionable log error messages instead of just failing.

Actual solution

Submit images & credentials at the same time, in the frontend they should be in the same form. This way they are validated at the same time and we are sure that the image specified will always be valid with the credentials provided.