zanetu / direct_google_images

Direct Google Images
24 stars 3 forks source link

Need Fix #11

Open seamoonz opened 3 years ago

seamoonz commented 3 years ago

When I type for example "monkey" and click the first picture it goes to Google's main page. After recent changes on Google now your script works in such way for the most pictures.

Example link: https://www.google.com.tr/search?q=monkey&tbm=isch&ved=2ahUKEwjn8pup1YDvAhUOShoKHYDmA9gQ2-cCegQIABAA&oq=monkey&gs_lcp=CgNpbWcQAzIECAAQQzICCAAyBAgAEEMyBAgAEEMyAggAMgIIADICCAAyAggAMgIIADICCABQvFRY8IMBYNSFAWgAcAB4AIABngGIAbYGkgEDMC42mAEAoAEBqgELZ3dzLXdpei1pbWewAQDAAQE&sclient=img&ei=dU01YKfkAY6UaYDNj8AN&bih=714&biw=1146&safe=off

zanetu commented 3 years ago

I cannot reproduce the issue in Chrome 88.0.4324.182 + Tampermonkey BETA 4.12.6127 with the link you provided. (See the screencast below.) Maybe your regional Google (in Turkey?) has a display different from mine. Tab-1614141816383

Try updating your browser along with userscript manager (Tampermonkey?) and disabling other plugins/userscripts. (Chrome incognito mode might be a convenient way to do this.)

seamoonz commented 3 years ago

I'm using FF 52.9 with Greasemonkey. I can't update browser because I'm using Xp Sp3 due to long time coming economical crisis I can't buy new computer so can't upgrade my OS.

zanetu commented 3 years ago

Just tried Firefox 52.9.0 and Greasemonkey 4.1 (the last version that supports Firefox 52) on Windows 10. Cannot reproduce the issue you described.

seamoonz commented 3 years ago

Tested with Greasemonkey 4.1 same result. On click on most of the pictures, new tab opens https://www.google.com/ page. Also if you install 4.1 to Firefox 52 on addons page there's no Greasemonkey tab so you can't manage any scripts that's why I use older version. 4.1 isn't really compatible.with Firefox 52

seamoonz commented 3 years ago

4.1 also cripples most of the scripts for Firefox 52.

zanetu commented 3 years ago

According to official release notes, GM 4.1 is compatible with FF 52:

Version 4.1 Released Dec 12, 2017 - 444.23 KB Works with firefox 52.0 and later, android 52.0 and later

I have no idea why your Firefox 52 isn't compatible with Greasemonkey 4.1.

What's the version of Greasemonkey that you are using? Could you provide a download link of that version? It would also be helpful if you could post your browser console info (CTRL+SHIFT+J) here.

seamoonz commented 3 years ago

Before Google's recent changes everything was fine. After that change same thing happened to another script called "Google Hit Hider" developer doesn't see any problem with latest Greasemonkey however legacy users like me reported it. So he modified single line and script worked for legacy users again. You can see it here: https://greasyfork.org/en/scripts/1682-google-hit-hider-by-domain-search-filter-block-sites/discussions/76491

I'm using version Greasemonkey 3.17. Direct link of it: https://www.aymavisi.org/gs.xpi

Console info: https://www.aymavisi.org/bc.txt

zanetu commented 3 years ago

Just tried the Greasemonkey 3.17 you provided. Nevertheless, my userscript works as expected and does not report any error. (See the screenshot below. )

temp

I skimmed your console output and noticed quite a few errors, most of which stemmed from an extension called firefox-dict-switcher and Google Hit Hider by Domain. While none of those errors is related to my userscript, it should be noted that errors caused by other userscripts/extensions may also hinder functionality of my userscript. The code change of Google Hit Hider by Domain that you referred to has nothing to do with my userscript, since my userscript does not use "GM." functions.

Simply put, there is nothing I can "fix" in my code.

seamoonz commented 3 years ago

Okay, thanks lot for caring & hard working.

Best Regards

p1nkyy commented 3 years ago

Hi, I think Google changes something and this script doesn't work as per September 2021. Please help? @zanetu

Firefox 92 & Tampermonkey Beta 4.14

zanetu commented 3 years ago

Hi, I think Google changes something and this script doesn't work as per September 2021. Please help? @zanetu

Firefox 92 & Tampermonkey Beta 4.14

Hi,

Works for me (with no error reported in console) on Firefox 92.0 (latest version) with Tampermonkey Beta 4.14.6143 (latest version). The search keyword I tested is "red" and the resulting test link is as follows.

https://www.google.com/search?q=red&hl=en&tbm=isch&source=hp&biw=862&bih=357&ei=5YRFYdOeOIyQtAbq8qjoCQ&oq=red&gs_lcp=CgNpbWcQAzIICAAQgAQQsQMyCAgAEIAEELEDMggIABCABBCxAzIICAAQgAQQsQMyCAgAEIAEELEDMggIABCABBCxAzIFCAAQgAQyCAgAEIAEELEDMggIABCABBCxAzIICAAQgAQQsQM6CwgAEIAEELEDEIMBUD1Y0wJgqwZoAHAAeACAAcQCiAHfBJIBBTItMS4xmAEAoAEBqgELZ3dzLXdpei1pbWc&sclient=img&ved=0ahUKEwiTpfW48IfzAhUMCM0KHWo5Cp0Q4dUDCAY&uact=5

Screenshot:

direct_google_images

Please provide me with your test link and a similar screenshot containing console output. Remember to disable irrelevant add-ons and all userscripts except Direct Google Images before carrying out your test, which helps narrow down the root cause of your problem.

p1nkyy commented 3 years ago

Hi, so sorry, it was a false alarm. I installed a new add-on named Universal Bypass which I think caused it. Thanks for your response & sorry for this. I know this is out of topic but any idea on how to set it so it doesn't clash with Direct Google Images.

zanetu commented 3 years ago

Hi, so sorry, it was a false alarm. I installed a new add-on named Universal Bypass which I think caused it. Thanks for your response & sorry for this. I know this is out of topic but any idea on how to set it so it doesn't clash with Direct Google Images.

Hi, I noticed that Universal Bypass stopped Google Images from working properly even when Tampermonkey is disabled. So it's by no means a problem that I am supposed to look into.